Follow-up from "add system 'parameters'"
The following discussion from !275 (merged) should be addressed:
-
@jbweston started a discussion: (+1 comment) We should consider removing the parameter check in the try/catch block of
kwant.builder._FinalizedBuilderMixin.hamiltonian
now that such a check exists inhamiltonian_submatrix
(ashamiltonian
is anyway a low-level API, and we could remove some code duplication this way).However, there are other places in Kwant (operators, though maybe there are others) where we use
hamiltonian
directly and any exceptions bubble up to user code. We would have to ensure that we pass the correct parameters tohamiltonian
, rather than just everything.