Operator.where limitations
I have encountered two problems with current implementation of where:
- The docstring right now says "If
syst
is not a finalized Builder, then this should be a sequence of integers." However was unclear to me that when the system is a finalizedBuilder
, thenwhere
must be a sequence of sites. Aside from the docstring imprecision, I find this limitation a bit arbitrary, and I believe it's better to also allow providewhere
as ints for finalized builders. - The finalized builders are detected by an instance check, requiring in an import of
builder.py
. I suggest to use an attribute check forid_by_site
instead, and not import builder at all.