Commit 8f2f1a96 authored by Joseph Weston's avatar Joseph Weston
Browse files

change default 'shutdown_executor' to False

Shutting down executors that are passed in by the user is not a
good default. Previously this was useful because ipykernels would
not shut down correctly because of some weird interaction with open
'concurrent.futures.Executor's, but this has since been fixed.
parent a19d6a84
Pipeline #8913 failed with stage
in 1 minute and 50 seconds
......@@ -71,7 +71,7 @@ class BaseRunner:
of cores available in 'executor'.
log : bool, default: False
If True, record the method calls made to the learner by this runner
shutdown_executor : Bool, default: True
shutdown_executor : Bool, default: False
If True, shutdown the executor when the runner has completed. If
'executor' is not provided then the executor created internally
by the runner is shut down, regardless of this parameter.
......@@ -87,7 +87,7 @@ class BaseRunner:
def __init__(self, learner, goal, *,
executor=None, ntasks=None, log=False,
shutdown_executor=True):
shutdown_executor=False):
self.executor = _ensure_executor(executor)
self.goal = goal
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment