Skip to content
Snippets Groups Projects

(LearnerND) Evaluate less circumspheres

Merged Jorn Hoofwijk requested to merge 80--evaluate-less-circumspheres into master
All threads resolved!

it prunes some circumcircles faster it results in: ~20% faster in 2d ~40% faster in 3d

Helps to speed up LearnerND a bit see (#80)

Merge request reports

Pipeline #11586 passed

Pipeline passed for 1e33f914 on 80--evaluate-less-circumspheres

Test coverage 78.00% (0.00%) from 1 job

Merged by Joseph WestonJoseph Weston 6 years ago (Aug 20, 2018 11:57am UTC)

Loading

Pipeline #11591 passed

Pipeline passed for 50898f7d on master

Test coverage 78.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Other than those comments we're good to go.

    @anton-akhmerov confirm that merging this is not contingent on your comment about ASV.

  • @anton-akhmerov confirm that merging this is not contingent on your comment about ASV.

    It is indeed not contingent. I mainly wanted to document in the MR discussion how the benchmark is established.

  • assigned to @Jorn

  • Jorn Hoofwijk added 1 commit

    added 1 commit

    • 1e33f914 - remove obsolete condition and add some comments

    Compare with previous version

  • Jorn Hoofwijk resolved all discussions

    resolved all discussions

  • should be good to merge now

  • merged

  • Joseph Weston mentioned in commit 50898f7d

    mentioned in commit 50898f7d

  • Please register or sign in to reply
    Loading