Skip to content
Snippets Groups Projects

Add LearnerND that does not interpolate the values of pending points

Merged Jorn Hoofwijk requested to merge 52--dont-interpolate-in-2D into master

it has some basic functionality now, there are still some things I am going to fix before we can actually use it:

TODO's:

  • add LearnerND
  • make a generic loss function that zooms in on deviations
  • make a better generic loss function (separate issue)
  • allow asking multiple points in one go
    • take pending points into account when choosing a new point
  • come up with a better choose_point_in_simplex (separate issue)
  • loss_per_simplex should only take a single simplex as input, not the entire triangulation
  • make Learner2D a child class of LearnerND (like a special case of the general case)
  • Performance
    • do not recompute triangulation so often
    • do not recompute losses for simplices of which you already know the loss
  • Triangulation: flip edges when it's beneficial
  • add tests for the LearnerND
  • add plot_slice functionality for 2D plots as well
  • add documentation (both user documentation as well as developer documentation) [currently docstrings and comments]
  • add 3d surface plot (separate issue)
  • add 3d crossection plot
  • scale Y-values to unit distance as well
  • allow for N-dimensional output (partially resolved, see #79 (closed))

Closes #52 (closed) and adds a LearnerND

Edited by Jorn Hoofwijk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jorn Hoofwijk added 4 commits

    added 4 commits

    • 7773197a - interpolator -> triangulation
    • e15e38e8 - make everything fail :(
    • c64bd65e - do nothing with the old triangulation, only check that simplices exist when needed
    • c5ad49b9 - add timer to print performance

    Compare with previous version

  • Jorn Hoofwijk resolved all discussions

    resolved all discussions

  • Jorn Hoofwijk added 9 commits

    added 9 commits

    • 88b8c0d2 - add triangulation
    • 5267352c - extra point
    • 4285a9dd - add check to whether the new point lies on the outer side of the face or
    • 0fb4257f - remove interior faces from list of hull-faces
    • 1e6b995f - take comments from anton into account
    • e2b11735 - Merge branch 'patch-triangulation-3d' into 'triangulation'
    • d2a3120e - remove _ip
    • 51f80e98 - Merge branch 'triangulation' into 52--dont-interpolate-in-2D
    • c45e01e3 - use custom triangulation

    Compare with previous version

  • Jorn Hoofwijk marked the checklist item allow asking multiple points in one go as incomplete

    marked the checklist item allow asking multiple points in one go as incomplete

  • Jorn Hoofwijk marked the checklist item take pending points into account when choosing a new point as incomplete

    marked the checklist item take pending points into account when choosing a new point as incomplete

  • Jorn Hoofwijk marked the checklist item loss_per_simplex should only take a single simplex as input, not the entire triangulation as incomplete

    marked the checklist item loss_per_simplex should only take a single simplex as input, not the entire triangulation as incomplete

  • Jorn Hoofwijk marked the checklist item do not recompute triangulation so often as completed

    marked the checklist item do not recompute triangulation so often as completed

  • Jorn Hoofwijk marked the checklist item do not recompute losses for simplices of which you already know the loss as completed

    marked the checklist item do not recompute losses for simplices of which you already know the loss as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading