Skip to content
Snippets Groups Projects

Fix relation between MultipleChoiceOption and FeedbackOption

Merged Ghost User requested to merge fix/mco-feedback-rel into develop
q deleted 100644 → 0
+ 0
24
diff --git a/zesje/api/feedback.py b/zesje/api/feedback.py
index 0ed472b..686afb5 100644
--- a/zesje/api/feedback.py
+++ b/zesje/api/feedback.py
@@ -140,14 +140,11 @@ class Feedback(Resource):
db.session.commit()

# Delete mc_options associated with this feedback option
- if fb.mc_option:
+ if fb.mc_option and fb.problem.exam.finalized:
+ return dict(status=401, message='Cannot delete feedback option'
+ + ' attached to a multiple choice option in a finalized exam.'), 401

- # Check if the exam with this feedback option
- if fb.problem.exam.finalized:
- return dict(status=401, message='Cannot delete feedback option'
- + ' attached to a multiple choice option in a finalized exam.'), 401
-
- db.session.delete(fb.mc_option)
- db.session.commit()
+ db.session.delete(fb.mc_option)
+ db.session.commit()

return dict(status=200, message=f"Feedback option with id {feedback_id} deleted."), 200
Loading