Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • kwant kwant
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 144
    • Issues 144
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 20
    • Merge requests 20
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • kwantkwant
  • kwantkwant
  • Merge requests
  • !389

Clean up linear algebra (related to modes)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Anton Akhmerov requested to merge sparse-modes into master Jun 13, 2021
  • Overview 8
  • Commits 5
  • Pipelines 15
  • Changes 8

I initially planned to implement a computation of modes with the sparse unit cell here. This, however, prompted code review and subsequent cleanup.

In summary, this MR:

  • Eliminates our custom wrappers for LAPACK lu and gen_eig. The former I reimplemented using scipy.linalg.lapack, and the latter wasn't used anywhere.
  • Shortens linalg tests by using pytest parameterization.
  • Uses a @ b instead of np.dot(a, b) or a.dot(b). This helps both readability and customization, because @ is properly dispatched by sparse matrices (unlike .dot).
  • Requires that setup_linsys takes square matrices as input. For some time already, we only passed square matrices to it, see this comment.
Edited Jun 14, 2021 by Anton Akhmerov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sparse-modes