Skip to content
Snippets Groups Projects
Commit c7fa5ef8 authored by Jorn Hoofwijk's avatar Jorn Hoofwijk Committed by Bas Nijholt
Browse files

fix #99

parent b645db34
No related branches found
No related tags found
1 merge request!100Resolve "Learner1D doesn't correctly set the interpolated loss when a point is added"
......@@ -137,7 +137,7 @@ class Learner1D(BaseLearner):
self._scale, self.data)
self.losses[x_left, x_right] = loss
start = self.neighbors_combined.bisect_right(x_left)
start = self.neighbors_combined.bisect_left(x_left)
end = self.neighbors_combined.bisect_left(x_right)
for i in range(start, end):
keys = self.neighbors_combined.keys()
......
......@@ -176,8 +176,8 @@ def test_learnerND_as_described_in_issue_99():
assert l.losses == {(0, 1): 0.25, (1, 2): 0.25}
assert l.losses_combined == {(0, 1): 0.25, (1, 2): 0.25, (2, 4.0): np.inf}
assert l.ask(1) == ([3], [np.inf])
# l.ask(1)
# assert l.ask(1) == ([3], [np.inf])
l.ask(1)
assert l.losses == {(0, 1): 0.25, (1, 2): 0.25}
assert l.losses_combined == {(0, 1): 0.25, (1, 2): 0.25, (2, 3.0): np.inf, (3.0, 4.0): np.inf}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment