Resolve "Learner1D fails when function returns a list instead of a numpy.array" (!101) · Merge requests · Quantum Tinkerer / adaptive · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Jorn Hoofwijk requested to merge 96--accept-lists into master 6 years ago

All threads resolved!

Closes #96 (closed)

Approval is optional

Activity

Bas Nijholt @basnijholt started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Bas Nijholt
Last reply by Bas Nijholt 6 years ago

Bas Nijholt added 1 commit 6 years ago

added 1 commit

a4af457b - use isinstance

Compare with previous version

Bas Nijholt resolved all discussions 6 years ago

resolved all discussions

Bas Nijholt @basnijholt · 6 years ago

Maintainer

LGTM, thanks @Jorn!

@jbweston could you merge this if you agree?

Bas Nijholt assigned to @jbweston 6 years ago

assigned to @jbweston

Joseph Weston @jbweston started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Bas Nijholt

Bas Nijholt added 1 commit 6 years ago

added 1 commit

e4bef8b0 - change 'float64' to 'float'

Compare with previous version

Bas Nijholt resolved all discussions 6 years ago

resolved all discussions

Joseph Weston @jbweston started a thread on the diff 6 years ago

Resolved 6 years ago by Joseph Weston

Joseph Weston added 1 commit 6 years ago

added 1 commit

a48d73f9 - add tests to verify that Learner2D and LearnerND accept lists

Compare with previous version

Joseph Weston resolved all discussions 6 years ago

resolved all discussions

Joseph Weston @jbweston · 6 years ago

Developer

LGTM

Joseph Weston added 13 commits 6 years ago

added 13 commits

a48d73f9...0dacb0e1 - 8 commits from branch master
f3d4ee9a - add test
4c8a1321 - fix #96 (closed)
0ea9f1f3 - use isinstance
98248dd6 - change 'float64' to 'float'
b18bfc1b - update test to verify that Learner2D and LearnerND accept lists

Compare with previous version

Toggle commit list

Joseph Weston enabled an automatic merge when the pipeline for succeeds 6 years ago

enabled an automatic merge when the pipeline for b18bfc1b succeeds

Joseph Weston mentioned in commit 6 years ago

mentioned in commit 6695ba17

Joseph Weston merged 6 years ago

merged

Bas Nijholt mentioned in issue #106 (closed) 6 years ago

mentioned in issue #106 (closed)

Please register or sign in to reply