Make the AverageLearner only return new points ... (!104) · Merge requests · Quantum Tinkerer / adaptive · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Bas Nijholt requested to merge average_learner_improvements into master 6 years ago

All threads resolved!

and introduce learner.pending_points to make it more similar to the rest of Adaptive.

I've added a test that will fail with the current master.

Edited 6 years ago by Bas Nijholt

Activity

Bas Nijholt added 1 commit 6 years ago
added 1 commit

8a1b94a7 - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'

Compare with previous version
Bas Nijholt added 19 commits 6 years ago
added 19 commits

73507b7e - introduce 'runner.retries' and 'runner.raise_if_max_retries'

9388b52e - add tests

4ae5d165 - partially solve the issue

5e91b1bd - fix #99 (closed)

1ed070dd - remove focus

74662907 - correct function names

7972db03 - fix typo in logic

962ba684 - dedent common code in 'update_losses'

c79fe319 - shorten duplicate code in 'update_losses'

cffb05b9 - improve readability of 'update_losses'

316b5a43 - rename tests

c15f095e - change code to be more explicit in my humble opinion

224b8cfc - add some comments to learner1D.update_losses()

a1f79392 - fix syntax error

a4e7f568 - partially remove the need for bisect when updating loss

31dd05db - remove code that is never executed

225fb87f - slighty change some comments

4e45b249 - add test that makes sure that the 'AverageLearner' only returns new points

0d190aed - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'

Compare with previous version
Toggle commit list
Bas Nijholt added 20 commits 6 years ago
added 20 commits

0d190aed...cf4effee - 18 commits from branch master

62e46954 - add test that makes sure that the 'AverageLearner' only returns new points

78cd74eb - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'

Compare with previous version
Bas Nijholt added 1 commit 6 years ago
added 1 commit

1f3a3fb1 - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'

Compare with previous version
Bas Nijholt changed the description 6 years ago

changed the description
Bas Nijholt assigned to @jbweston 6 years ago

assigned to @jbweston
Bas Nijholt added AverageLearner Bug labels 6 years ago

added AverageLearner Bug labels
Joseph Weston @jbweston started a thread on an old version of the diff 6 years ago

Resolved 6 years ago by Bas Nijholt
Last reply by Bas Nijholt 6 years ago

Bas Nijholt added 6 commits 6 years ago

added 6 commits

1f3a3fb1...e378367d - 4 commits from branch master
52625378 - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'
25e8d80c - add test that makes sure that the 'AverageLearner' only returns new points

Compare with previous version

Joseph Weston @jbweston started a thread on the diff 6 years ago

Resolved 6 years ago by Bas Nijholt

Bas Nijholt added 1 commit 6 years ago

added 1 commit

429026cc - add test that makes sure that the 'AverageLearner' only returns new points

Compare with previous version

Bas Nijholt added 2 commits 6 years ago

added 2 commits

0f5c8f46 - add test that makes sure that the 'AverageLearner' only returns new points
c1d0885d - fix that the 'AverageLearner' only returns new points, and introduce 'learner.pending_points'

Compare with previous version

Bas Nijholt resolved all discussions 6 years ago

resolved all discussions

Bas Nijholt mentioned in merge request !103 (merged) 6 years ago

mentioned in merge request !103 (merged)

Joseph Weston @jbweston · 6 years ago

Developer

LGTM, top notch as always.

Joseph Weston merged 6 years ago

merged

Joseph Weston mentioned in commit 6 years ago

mentioned in commit 340cd6aa

Bas Nijholt mentioned in issue #106 (closed) 6 years ago

mentioned in issue #106 (closed)

Please register or sign in to reply