Introduce 'tell_pending' which replaces 'tell(x, None)'
and I also tackle
lower_bound <= learner.ask()[0] <= upper_bound
- if we
tell(x, y)
withx
outside the bounds, the point should be added todata
, but not any of the other internal datastructures. This will mean that the point will be "invisible" to the learning algorithm, and only useful for plotting and data extraction
for both the Learner1D
and Learner2D
in that MR. I included this in here to avoid merge conflicts later.
Edited by Bas Nijholt
Merge request reports
Activity
added 1 commit
- eb917948 - AverageLearner: create 'tell_pending' which deprecates 'tell(x, None)'
added 1 commit
- 5e1758fb - AverageLearner: create 'tell_pending' which deprecates 'tell(x, None)'
added 1 commit
- b650fcd3 - LearnerND: create 'tell_pending' which deprecates 'tell(x, None)'
added 1 commit
- ccbdd095 - LearnerND: create 'tell_pending' which deprecates 'tell(x, None)'
added 1 commit
- 49383cde - IntegratorLearner: implement 'ask(n, tell_pending=False)'
added 1 commit
- a8693ed6 - SKOptLearner: create 'tell_pending' which deprecates 'tell(x, None)'
added 11 commits
-
b034e437 - 1 commit from branch
master
- 8d9d0297 - 1D: create 'tell_pending' which deprecates 'tell(x, None)'
- 74d53009 - 2D: create 'tell_pending' which deprecates 'tell(x, None)'
- adc0c67a - AverageLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- f7463ba8 - LearnerND: create 'tell_pending' which deprecates 'tell(x, None)'
- aa68980e - BalancingLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 33f6a01b - BalancingLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 600fbe29 - DataSaver: create 'tell_pending' which deprecates 'tell(x, None)'
- d28e7abe - IntegratorLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- a8472d09 - IntegratorLearner: implement 'ask(n, tell_pending=False)'
- 6a1f869e - SKOptLearner: create 'tell_pending' which deprecates 'tell(x, None)'
Toggle commit list-
b034e437 - 1 commit from branch
added 5 commits
- df231d6d - BaseLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 611426b8 - DataSaver: create 'tell_pending' which deprecates 'tell(x, None)'
- 28f86adb - IntegratorLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 4357bc3f - IntegratorLearner: implement 'ask(n, tell_pending=False)'
- 842ebd22 - SKOptLearner: create 'tell_pending' which deprecates 'tell(x, None)'
Toggle commit listassigned to @jbweston
added 14 commits
-
842ebd22...f846e1fb - 3 commits from branch
master
- 90aa2a69 - 1D: create 'tell_pending' which deprecates 'tell(x, None)'
- db76938c - 2D: create 'tell_pending' which deprecates 'tell(x, None)'
- f761e74f - AverageLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 62c9663c - LearnerND: create 'tell_pending' which deprecates 'tell(x, None)'
- 899482df - BalancingLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 7ea91530 - BaseLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 9bb76e69 - DataSaver: create 'tell_pending' which deprecates 'tell(x, None)'
- 21d540c0 - IntegratorLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- bf1186b6 - IntegratorLearner: implement 'ask(n, tell_pending=False)'
- 8f074e30 - SKOptLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 28bcb6bb - remove 'xfail' marker for 'LearnerND' inside 'BalancingLearner'
Toggle commit list-
842ebd22...f846e1fb - 3 commits from branch
added 1 commit
- 35b137af - remove 'xfail' marker for 'LearnerND' inside 'BalancingLearner' and reveal a bug
added 12 commits
-
a48fc888 - 1 commit from branch
master
- 982d69a5 - 1D: create 'tell_pending' which deprecates 'tell(x, None)'
- 4480ce25 - 2D: create 'tell_pending' which deprecates 'tell(x, None)'
- 4eb68018 - AverageLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 9206b46b - LearnerND: create 'tell_pending' which deprecates 'tell(x, None)'
- b29f8abd - BalancingLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- 0b6d2a8b - BaseLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- b3ce3317 - DataSaver: create 'tell_pending' which deprecates 'tell(x, None)'
- 1c16c995 - IntegratorLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- cc36d360 - IntegratorLearner: implement 'ask(n, tell_pending=False)'
- 5ac5766e - SKOptLearner: create 'tell_pending' which deprecates 'tell(x, None)'
- fd4c076a - remove 'xfail' marker for 'LearnerND' inside 'BalancingLearner' and reveal a bug
Toggle commit list-
a48fc888 - 1 commit from branch
added 1 commit
- e636e65a - add 'xfail' to 'LearnerND' for 'BalancingLearner' and link issue
mentioned in issue #105 (closed)
mentioned in merge request !106 (merged)
added 1 commit
- b748b6c0 - 1D: do not use points outside of the bounds in the point chosing algorithms
added 1 commit
- 2bdb12b5 - 2D: do not use points outside of the bounds in the point chosing algorithms
mentioned in commit 1b9ef594
mentioned in issue #106 (closed)
Please register or sign in to reply