Skip to content
Snippets Groups Projects

Resolve "(LearnerND) add iso-surface plot feature"

Merged Jorn Hoofwijk requested to merge 112-learnernd-add-iso-surface-plot-feature into master

Closes #112 (closed)

Edited by Jorn Hoofwijk

Merge request reports

Pipeline #13021 passed

Pipeline passed for 49ad3c6c on 112-learnernd-add-iso-surface-plot-feature

Test coverage 79.00% (-2.00%) from 1 job
Approval is optional

Merged by Bas NijholtBas Nijholt 6 years ago (Oct 25, 2018 10:30am UTC)

Merge details

Pipeline #13022 passed

Pipeline passed for 49ad3c6c on master

Test coverage 79.00% (-2.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bas Nijholt
  • Bas Nijholt added 1 commit

    added 1 commit

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • a2b5aca6 - import plotly only when using it

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 63175598 - add iso_surface_plot to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • b38edef8 - add iso_surface_plot to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 2 commits

    added 2 commits

    • 6b5cd171 - 1 commit from branch master
    • 354002ea - add iso_surface_plot to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 9aaa6c38 - add iso_surface_plot to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • c1c1b872 - improve 'notebook_extension'

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 9ed15f76 - improve 'notebook_extension'

    Compare with previous version

  • Bas Nijholt added 2 commits

    added 2 commits

    • 4e0090e6 - add iso_surface_plot to adaptive learnerND
    • 3e660922 - improve 'notebook_extension'

    Compare with previous version

  • Jorn Hoofwijk mentioned in merge request !127 (merged)

    mentioned in merge request !127 (merged)

  • Bas Nijholt added 4 commits

    added 4 commits

    Compare with previous version

  • Jorn Hoofwijk added 1 commit

    added 1 commit

    • 3f611327 - set lighting such that the plots look even better

    Compare with previous version

  • i have found why the surface looks so rough/ugly. It has to do with lighting.

    With this commit it should look nicer:

    image

  • Jorn Hoofwijk added 1 commit

    added 1 commit

    • dff5c5d9 - add plotly to environment.yml

    Compare with previous version

  • Jorn Hoofwijk resolved all discussions

    resolved all discussions

  • Jorn Hoofwijk resolved all discussions

    resolved all discussions

  • Jorn Hoofwijk added 2 commits

    added 2 commits

    • 8b0c5472 - also add an isoline feature
    • 260df457 - add ability to plot multiple isolines

    Compare with previous version

  • This plotly MR may be relevant: https://github.com/plotly/plotly.js/pull/2752

    (but it's work in progress on their side)

    Edited by Anton Akhmerov
  • It would be great if we could add some example to the documentation.

    However, I don't think that the plotly plots will correctly show up ATM.

    Related: https://github.com/spatialaudio/nbsphinx/issues/128

  • Bas Nijholt added 24 commits

    added 24 commits

    Compare with previous version

  • Bas Nijholt added 2 commits

    added 2 commits

    Compare with previous version

  • I've learned how to load them correctly, and we should be able to do so via jupyter-sphinx.

  • Bas Nijholt added 1 commit

    added 1 commit

    • 82605cfe - add a Plotly example to the docs

    Compare with previous version

  • It already works :)

    Screenshot_2018-10-19_at_16.48.28

  • BTW, we probably shoulnd't show the triangulation edges: these are mainly relevant for debugging, but they obscure the information about the function that's being learned.

  • Bas Nijholt added 4 commits

    added 4 commits

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 2fdfaa58 - add 'plot_isosurface' and 'plot_isoline' to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • c4deea80 - merge 'get_isosurface' and 'get_isoline'

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • e22f2dc2 - merge 'get_isosurface' and 'get_isoline'

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 190db37a - merge 'get_isosurface' and 'get_isoline'

    Compare with previous version

  • Bas Nijholt added 5 commits

    added 5 commits

    • 190db37a...1119d950 - 3 commits from branch master
    • a54799eb - add 'plot_isosurface' and 'plot_isoline' to adaptive learnerND
    • e13e1d52 - merge 'get_isosurface' and 'get_isoline'

    Compare with previous version

  • Bas Nijholt added 5 commits

    added 5 commits

    • f758d4b0 - documentation improvements
    • d1e4e270 - improve 'notebook_extension' and add 'plotly' as a dependency
    • 8eaecaec - add 'LearnerND.plot_3D' and add an example to the docs
    • a6c3f3a6 - add 'plot_isosurface' and 'plot_isoline' to adaptive learnerND
    • bcc4be84 - merge 'get_isosurface' and 'get_isoline'

    Compare with previous version

  • Bas Nijholt added 4 commits

    added 4 commits

    Compare with previous version

  • Bas Nijholt mentioned in issue #117

    mentioned in issue #117

  • Bas Nijholt added 7 commits

    added 7 commits

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 143b29fd - add 'plot_isosurface' and 'plot_isoline' to adaptive learnerND

    Compare with previous version

  • Bas Nijholt added 1 commit

    added 1 commit

    • 5708c4ca - add 'plot_isosurface' and 'plot_isoline' to adaptive learnerND

    Compare with previous version

  • @jbweston and @anton-akhmerov I rebased this, made some simplifications, and improved the docstrings.

    Merge if you are satisfied.

    Nice work @Jorn!

  • Joseph Weston
  • Joseph Weston
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading