More efficient 'tell_many'

import adaptive

def f(x, offset=0):
    a = 0.01
    return x + a**2 / (a**2 + (x - offset)**2)

learner = adaptive.Learner1D(f, bounds=(-1, 1))
adaptive.runner.simple(learner, goal=lambda l: l.npoints > 200)

Timing new implementation

%%timeit
learner2 = adaptive.Learner1D(f, bounds=(-1, 1))
learner2.tell_many(*zip(*learner.data.items()))

1.17 ms ± 24.9 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

Timing old implementation

%%timeit
learner2 = adaptive.Learner1D(f, bounds=(-1, 1))
for x, y in learner.data.items():
    learner2.tell(x, y)

6.82 ms ± 447 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

This makes it ~6 times faster for functions that return scalars and is >10 times faster for vectors.

added 1 commit

• 0b20c52a - fix some of the tests

Compare with previous version

mentioned in issue #105 (closed)

added 70 commits

• 0b20c52a...957d25fd - 67 commits from branch master
• ee4b3336 - 1D: implement a more efficient 'tell_many'
• 1dff371c - 1D: test the more efficient 'tell_many'
• 620a1906 - fix some of the tests

Compare with previous version

added 2 commits

• 8b47a31c - 1D: implement a more efficient 'tell_many'
• 4575cdf5 - 1D: test the more efficient 'tell_many'

Compare with previous version

added 5 commits

• 4575cdf5...4dc4400a - 2 commits from branch master
• 16afdb70 - 1D: implement a more efficient 'tell_many'
• 786de33d - 1D: test the more efficient 'tell_many'
• 3832c91d - wip

Compare with previous version

added 2 commits

• dfd788f7 - 1D: test the more efficient 'tell_many'
• 57532610 - 1D: implement a more efficient 'tell_many'

Compare with previous version

added 2 commits

• 4f6237ef - 1D: implement a more efficient 'tell_many'
• 535d04d0 - 1D: test the more efficient 'tell_many'

Compare with previous version

added 2 commits

• d7d39796 - 1D: sort the data when plotting a 'holoviews.Path'
• 2b75bb05 - 1D: simplify 'learner.vdim'

Compare with previous version

unmarked as a Work In Progress

changed the description

added 1 commit

• fc24cc22 - 1D: simplify 'learner.vdim'

Compare with previous version

added 1 commit

• bdaf5187 - 1D: simplify 'learner.vdim'

Compare with previous version

@jbweston I think this works as expected now.

Do you think we need more tests?

assigned to @jbweston

added 4 commits

• c3a56d36 - 1D: implement a more efficient 'tell_many'
• 793c4452 - 1D: test the more efficient 'tell_many'
• 57fd1fc1 - 1D: sort the data when plotting a 'holoviews.Path'
• f1d4f04b - 1D: simplify 'learner.vdim'

Compare with previous version

resolved all discussions

changed milestone to %v0.6

added 7 commits

• f1d4f04b...73103e61 - 3 commits from branch master
• 775190fe - 1D: implement a more efficient 'tell_many'
• 51cfc988 - 1D: test the more efficient 'tell_many'
• 3bab1b6a - 1D: sort the data when plotting a 'holoviews.Path'
• c32600b4 - 1D: simplify 'learner.vdim'

Compare with previous version

added 5 commits

• 318f27f7 - 1 commit from branch master
• 1c0145e3 - 1D: implement a more efficient 'tell_many'
• 3f667fbd - 1D: test the more efficient 'tell_many'
• 537415c0 - 1D: sort the data when plotting a 'holoviews.Path'
• fc106084 - 1D: simplify 'learner.vdim'

Compare with previous version

added 4 commits

• 7e17e80e - 1D: implement a more efficient 'tell_many'
• d15c1908 - 1D: test the more efficient 'tell_many'
• 3c93160f - 1D: sort the data when plotting a 'holoviews.Path'
• 904eeebc - 1D: simplify 'learner.vdim'

Compare with previous version

added 4 commits

• b3495b7d - 1D: implement a more efficient 'tell_many'
• 68d42e64 - 1D: test the more efficient 'tell_many'
• a00f027e - 1D: sort the data when plotting a 'holoviews.Path'
• 2932201b - 1D: simplify 'learner.vdim'

Compare with previous version

added 4 commits

• ef0bed00 - 1D: implement a more efficient 'tell_many'
• a09240df - 1D: test the more efficient 'tell_many'
• c40e7e57 - 1D: sort the data when plotting a 'holoviews.Path'
• 795dd8a9 - 1D: simplify 'learner.vdim'

Compare with previous version

added 4 commits

• 86014bec - 1D: implement a more efficient 'tell_many'
• c67e42fd - 1D: test the more efficient 'tell_many'
• 9bcde87b - 1D: sort the data when plotting a 'holoviews.Path'
• 79b6331e - 1D: simplify 'learner.vdim'

Compare with previous version

added 4 commits

• 5868fffc - 1D: implement a more efficient 'tell_many'
• b0e13973 - 1D: test the more efficient 'tell_many'
• 33cb2800 - 1D: sort the data when plotting a 'holoviews.Path'
• 0642b997 - 1D: simplify 'learner.vdim'

Compare with previous version

I am fairly certain that the tell_many code is 100% correct now.

However the test doesn't pass because if self._scale[1] > 2 * self._oldscale[1], if I change it to if self._scale[1] > self._oldscale[1] the attributes are identical.

added 1 commit

• d1955676 - 1D: add 'force' keyword only argument to 'tell_many' for testing purposes and fix the tests

Compare with previous version

added 5 commits

• dc50e96e - 1D: implement a more efficient 'tell_many'
• 44b445a8 - 1D: test the more efficient 'tell_many'
• 880740c4 - 1D: sort the data when plotting a 'holoviews.Path'
• 17511d3b - 1D: simplify 'learner.vdim'
• 65383ac2 - 1D: add 'force' keyword only argument to 'tell_many' for testing purposes and fix the tests

Compare with previous version

added 4 commits

• 39f52fd6 - 1D: implement a more efficient 'tell_many'
• 2090292f - 1D: test the more efficient 'tell_many'
• 7a375eba - 1D: sort the data when plotting a 'holoviews.Path'
• 9fdb3e4c - 1D: simplify 'learner.vdim'

Compare with previous version

@jbweston I fixed the issue mentioned in my previous comment. All done now

resolved all discussions

added 4 commits

• 601df656 - 1D: implement a more efficient 'tell_many'
• 66896b75 - 1D: test the more efficient 'tell_many'
• dd272368 - 1D: sort the data when plotting a 'holoviews.Path'
• 39ee5798 - 1D: simplify 'learner.vdim'

Compare with previous version

added 3 commits

• aedb0895 - 1D: test the more efficient 'tell_many'
• 6e671e3e - 1D: sort the data when plotting a 'holoviews.Path'
• 28d277d9 - 1D: simplify 'learner.vdim'

Compare with previous version

added 3 commits

• 94e97d08 - 1D: test the more efficient 'tell_many'
• c5b563dc - 1D: sort the data when plotting a 'holoviews.Path'
• f7f1a99e - 1D: simplify 'learner.vdim'

Compare with previous version

mentioned in issue #106 (closed)

added 3 commits

• 9b3fb298 - 1D: test the more efficient 'tell_many'
• d31f408d - 1D: sort the data when plotting a 'holoviews.Path'
• 580e21d5 - 1D: simplify 'learner.vdim'

Compare with previous version

assigned to @basnijholt

resolved all discussions

added 7 commits

• 580e21d5...dc57ba19 - 3 commits from branch master
• 8bafea3c - 1D: implement a more efficient 'tell_many'
• d00bde9d - 1D: test the more efficient 'tell_many'
• 97f7b24d - 1D: sort the data when plotting a 'holoviews.Path'
• 18618f85 - 1D: simplify 'learner.vdim'

Compare with previous version

assigned to @jbweston

@jbweston I made the changes you suggested, thanks for the review.