Resolve "DeprecationWarning: sorted_dict.iloc is deprecated. Use SortedDict.keys() instead." (!98) · Merge requests · Quantum Tinkerer / adaptive · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Jorn Hoofwijk requested to merge 92--iloc-depricated into master 6 years ago

Closes #92 (closed)

This might impact performance, since sorted_dict.keys() might be O(N), but I am not 100 percent certain on this, but it sounds logical

Edited 6 years ago by Joseph Weston

Activity

Joseph Weston @jbweston · 6 years ago

Developer

lookup in sorted_dict.keys() is log(N): http://www.grantjenks.com/docs/sortedcontainers/sorteddict.html#sortedcontainers.SortedKeysView

iloc was just a cached reference to a SortedKeysView, so the runtime is the same.
Joseph Weston added 9 commits 6 years ago
added 9 commits

f4796aed...0dacb0e1 - 8 commits from branch master

589ff9f0 - replace iloc with keys, this may impact performance

Compare with previous version
Joseph Weston unmarked as a Work In Progress 6 years ago

unmarked as a Work In Progress
Joseph Weston changed the description 6 years ago

changed the description
Joseph Weston @jbweston · 6 years ago

Developer

LGTM
Joseph Weston added 1 commit 6 years ago
added 1 commit

2c632463 - replace 'SortedDict.iloc' with 'SortedDict.keys()'

Compare with previous version
Joseph Weston added 7 commits 6 years ago
added 7 commits

2c632463...6695ba17 - 6 commits from branch master

93562ad3 - replace 'SortedDict.iloc' with 'SortedDict.keys()'

Compare with previous version
Joseph Weston merged 6 years ago

merged
Bas Nijholt mentioned in issue #106 (closed) 6 years ago

mentioned in issue #106 (closed)

Please register or sign in to reply