Skip to content
Snippets Groups Projects

Several multiple choice option fixes

Merged Several multiple choice option fixes
mcq-fixes into develop
1 unresolved thread
Merged Ghost User requested to merge mcq-fixes into develop
1 unresolved thread

Addresses issues mentioned in #29 (closed).

  • Make migrations compatible with the migrations on master

Closes #29 (closed)

Edited by Ghost User

Merge request reports

Pipeline #17575 passed

Stage: build
Stage: test

Pipeline passed for 7b69173a on mcq-fixes

Merged by avatar (Mar 17, 2025 4:13am UTC)

Loading

Pipeline #17578 passed

Stage: build
Stage: test

Pipeline passed for 565c3bc2 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
zesje/database.py
166 166
167 167 x = Column(Integer, nullable=False)
168 168 y = Column(Integer, nullable=False)
169 page = Column(Integer, nullable=False)
170
171 169 label = Column(String, nullable=True)
172 170
173 problem_id = Column(Integer, ForeignKey('solution.id'), nullable=False)
174 feedback_id = Column(Integer, ForeignKey('feedback_option.id'), nullable=True)
171 problem_id = Column(Integer, ForeignKey('problem.id'), nullable=False)
172 feedback_id = Column(Integer, ForeignKey('feedback_option.id'), nullable=False)
  • jtimotei
  • Ghost User added 1 commit

    added 1 commit

    • 1e8d40bd - Changed mistake in database.py back

    Compare with previous version

  • Ghost User resolved all discussions

    resolved all discussions

  • Hidde Leistra
  • Ghost User resolved all discussions

    resolved all discussions

    • Ghost User
      Ghost User @ghost ·
      Author Contributor

      I will still need to make the migrations on this branch compatible with master.

    • Ghost User
      Ghost User @ghost ·
      Author Contributor

      This is not possible in SQLite since it does not support changing column names.

      Upon creating a new migration file, and trying to migrate I get the following error.

      ERROR [alembic.env] No support for ALTER of constraints in SQLite dialect
    • Please register or sign in to reply
  • Ghost User marked as a Work In Progress

    marked as a Work In Progress

  • Ghost User changed the description

    changed the description

  • Ghost User changed the description

    changed the description

  • Ghost User added 1 commit

    added 1 commit

    • 7b69173a - Added yarn migrate-down call

    Compare with previous version

  • Ghost User unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ghost User marked the checklist item Make migrations compatible with the migrations on master as completed

    marked the checklist item Make migrations compatible with the migrations on master as completed

  • Ghost User changed target branch from master to develop

    changed target branch from master to develop

  • Ghost User merged

    merged

  • Ghost User mentioned in commit 565c3bc2

    mentioned in commit 565c3bc2

  • Ghost User mentioned in issue #29 (closed)

    mentioned in issue #29 (closed)

    • Please register or sign in to reply