Resolve "Make BaseRunner an abstract base class"
Closes #107 (closed)
Merge request reports
Activity
added 1 commit
- 19b19767 - make baserunner abstract with some abstract methods
changed milestone to %v0.6
mentioned in issue #106 (closed)
added 13 commits
-
667d35fb...c26ac920 - 12 commits from branch
master - 3e42a151 - make baserunner abstract with some abstract methods
-
667d35fb...c26ac920 - 12 commits from branch
added 1 commit
- 5478f195 - make baserunner abstract with some abstract methods
I don't think that we should do this. At the moment the Runner has sort of "evolved" (we put a bunch of common code in the base class to enable sharing) but we haven't done another design iteration.
We need to look at the current use-cases of the runner to decide what it makes sense to have. Notably the addition of extra "meta" tasks (e.g. collecting runtime information), and how to support different running strategies.
This merge request makes a set of choices about what all runners must provide, and I'm not sure that we want all of this.
IMO we need to have a proper design meeting where we hash all this out
added 63 commits
-
5478f195...38163004 - 61 commits from branch
master - da423943 - make baserunner abstract with some abstract methods
- 8b2d1503 - make '_submit' a method
-
5478f195...38163004 - 61 commits from branch
@jbweston I made the changed we discussed in person. Merge if you like.
assigned to @jbweston
