LearnerND triangulation incomplete
In visualizing the 3D triangulation of the LearnerND I discovered that there must be a bug because it's incomplete.
See this notebook.
Activity
assigned to @Jorn
And I was hoping this only happens for the anisotropic case. It may or may not be closely related to !90 (comment 19443)
Also I do really like plotly, last week I've also been playing around with it
I can actually confirm this is exactly what happens in !90 (comment 19443)
the simplex connected to the vertex in the top-right overlaps with other simplices, while simplices should actually never overlap
I have actually never observed this apart from the anisotropic learner, so I am partly surprised and worried and relieved at the same time.
I am certain I can fix this, but I am unsure how long it will take, but I will make sure it gets fixed.
I noticed there is some error in the visualisation as well, using this notebook, and replacing the runner with a simple runner:
adaptive.runner.simple(learner, goal=lambda l: l.npoints >= 5)I saw that not all edges are plotted while they are present. I will rewrite the notebook a little to fix it, and to see if the missing/overlapping simplices still occur, (i think they might)
Using the following notebook, this is no longer visible: LearnerND_plotly_110.ipynb
I think showing the triangulation is indeed very effective for debugging and for example finding out what goes wrong in what cases in !90.
I will take back what I said here: #110 (comment 19620) It was in fact not the same thing as in !90 (comment 19443)
I also think this issue may be closed.
removed Bug label
mentioned in issue #125 (closed)
