Resolve "Learner1D's bound check algo in self.ask doesn't take self.data or self.pending_points"

Closes #95 (closed)

• currently the tests fail, this should be fixed
• add some more tests to check uniformity of the return value

mentioned in merge request !97 (merged)

added 2 commits

• e3408a67 - remove assertion
• 1f4fb5ce - tell data at correct placed, also pop losses_combined

Compare with previous version

marked the checklist item currently the tests fail, this should be fixed as completed

added 1 commit

• 30e4abfc - add some tests to check the correctness of the new implementation of ask

Compare with previous version

marked the checklist item add some more tests to check uniformity of the return value as completed

unmarked as a Work In Progress

changed the description

maybe rewrite Learner1D.ask to be more readable

added 1 commit

• 4220fb53 - remove focus

Compare with previous version

Very nice!

I feel like the "missing bounds == 1 or 2" code can be simplified, but didn't take the time yet.

assigned to @jbweston

assigned to @Jorn

added 37 commits

• 4220fb53...cf4effee - 36 commits from branch master
• 8437e364 - Merge branch 'master' into 95--take-known-points-into-account-when-asking-bounds

Compare with previous version

added 2 commits

• 9db3563f - x -> xs
• 4f70db6f - instead of sorting, use assert to make sure order is correct

Compare with previous version

added 4 commits

• 8aa9e5d0 - condense 2 lines -> 1 line
• dbab9c34 - sets -> lists
• d4e0c695 - _
• d6dfa212 - rewrite learner1d.ask to have less iffs

Compare with previous version

added Bug Learner1D labels

added 4 commits

• 52ef05c4 - split ask into function that changes the state and a pure function
• 87eec7c4 - some refactoring of learner1d
• bf1f9d18 - move linspace to module level
• 7b34a038 - move finiteloss

Compare with previous version

added 1 commit

• 9c015a90 - put logic for splitting up the quals into a new function

Compare with previous version

added 9 commits

• 9c015a90...340cd6aa - 7 commits from branch master
• 0bc1a2e5 - 1D: add tests that check the point chosing when bounds are not present
• 61e1bf67 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 2 commits

• d8543e93 - 1D: add tests that check the point chosing when bounds are not present
• 800f6d89 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 2 commits

• 7507df9d - 1D: add tests that check the point chosing when bounds are not present
• 6341cff5 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• 37b4ddc7 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• a6e11211 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

resolved all discussions

assigned to @jbweston

added 1 commit

• 0dbfb684 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• 465e19da - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• b9ec5f5b - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

resolved all discussions

mentioned in issue #104 (closed)

added 1 commit

• 3bd66543 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

resolved all discussions

added 6 commits

• 3bd66543...f846e1fb - 4 commits from branch master
• 31baabd7 - 1D: add tests that check the point chosing when bounds are not present
• bef41424 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 3 commits

• a48fc888 - 1 commit from branch master
• 7ea49c1b - 1D: add tests that check the point chosing when bounds are not present
• a932f163 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

I made some small changes and squashed the commits into two logical commits.

@jbweston all your discussions are solved, merge if you are pleased.

added 1 commit

• bb713e29 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 18 commits

• bb713e29...1b9ef594 - 16 commits from branch master
• 5301fbe3 - 1D: add tests that check the point chosing when bounds are not present
• 0837260d - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• 75e2a740 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• 382efaf2 - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

added 1 commit

• f73a1abc - 1D: ensure that 'ask' takes 'learner.data' into consideration when the bounds are not present

Compare with previous version

mentioned in commit 957d25fd

merged