Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Q qsymm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Quantum Tinkerer
  • qsymm
  • Merge requests
  • !7

Bugfix/symbol normalizer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dániel Varjas requested to merge bugfix/symbol_normalizer into stable-1.2 Sep 02, 2019
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2
  • When initializing Model, symbol_normalizer was not applied when normalize=True. This was an oversight and resulted in inconsistent internal representations for identical models, especially when Model.subs is used.

  • test_Model_subs in test_model.py was changed to remove sensitivity to dict ordering, which caused problems with python=3.5.

  • test_Model was changed to test for the correct internal format.

  • Random number generator seed set for these tests.

Edited Sep 02, 2019 by Joseph Weston
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bugfix/symbol_normalizer