Skip to content
Snippets Groups Projects

Flakes for CI

Merged Flakes for CI
anton-akhmerov/kwant:flakes into master
Merged Anton Akhmerov requested to merge anton-akhmerov/kwant:flakes into master
  • I've switched on flakes in CI so that it can catch some simple errors.
  • Among cruft pyflakes has identified two actual bugs.

Right now pyflakes is too simple-minded to digest dynamic formation of __all__ in __init__.py, should we do something about it or should we rather silence pyflakes like I did?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christoph Groth
    Christoph Groth @cwg ·
    Owner

    Silencing flakes for __init__.py is certainly fine.

    The other warnings that appear are due to the disabled slicing code. We should probably remove this code properly (it can be added when needed), or make it usable. (But this is a separate issue from this one.)

    I don't even remember why we disabled the slicing. Do you?

    Edited by Christoph Groth
  • Anton Akhmerov
    Anton Akhmerov @anton-akhmerov ·
    Author Owner

    Because it relies on scotch, and we don't install scotch.

  • Anton Akhmerov Added 1 commit:

    Added 1 commit:

    • 3ad2f168 - use flakes in ci, fix flakes warnings
  • Anton Akhmerov mentioned in commit 533d7938

    mentioned in commit 533d7938

  • Anton Akhmerov Status changed to merged

    Status changed to merged

    • Please register or sign in to reply