discretizer: Stop using same names for functions and symbols
This is an alternative to !402 (closed) which I did not manage to get to work with pre-1.10 SymPy. For this patch, tests pass with both SymPy 1.7.1 and 1.10.1.
To me at least, this change makes the code easier to read by clearly distinguishing between symbols (A
and B
) and functions (F
and G
). However, since I do not have a deep understanding of discretizer's tests, I might be missing something subtle here. Still, the changes are only simple renames, so it would surprise me if they modify test functionality.
A final somewhat unrelated point:
I noticed that in function test_numeric_functions_with_parameter
, in line 515, i.e.
f_sym = sympy.lambdify(['A', 'x'], v)
one may change 'A'
to anything, for example 'XYZ'
, and the test still passes. This might be potentially a weakness of that test, but I hope it's just a benign redundancy.